AndiNo's Patch !?

[AndiNo]

Good evening guys^^
As I told some of you yesterday (while playing KF on Geisterbahn) I have found a way to export the KF scripts and change them. That may not be a big deal to some or even most of the UT-editing-guys here. However it was a great discovery for me because now I am able to edit all of KF's inner workings.
I didn't want to broadcast this too much because I had some troubles with it. The first script-exporter sucked and dropped some parts of the scripts - resulting in zombies without a skin (they all had some greenish default skin on them). Luckily the UnrealEd built-in exporter was much better.
To make a long story short^^: I'm a noob to UT coding, however I have already some experience in C++ programing. This way I figured out how things worked (at least to some extent). To find out whether I really could change something (make a difference ) I wanted to fix a bug. The result: It worked
It's not much, but good as a beginning. I fixed the "Wave End Cash Bonus"-bug. Only the first player in the list received the bonus, all others were skipped. Although I thought that I would rather make a mistake than the KF Coding Team, it seems that the function responsible for giving out the bonus was, well, nearly total crap ;D
I tried it now with bots, although it should work with normal players, too. Now every player gets the bonus divided by the current (living?) player count as it was intended to be.

There is one downside however. Although the scripts compiled nearly without errors, there shouldn't have been ANY errors. The scripts exported with UED were much better than those from the other exporter, however they still don't seem to be perfect. When I compile the package KFGui it works, however all fonts in the game/menu are yellow instead of red. Dunno where this comes from...
That said I don't know how "secure" it is to give out these changed scripts. I don't want to make things worse than they are (maybe there are other things not working "below the surface") Maybe one time (when he returns) Alex will give me the scripts he used for compiling...

I will try to fix some other bugs, as the fixed code should be easily implemented into Alex's code if he hands it over. If there are people who really want to have this "patch" knowing that it "could" be worse, I could give it out though. AFAIK the server AND the client need to have that, otherwise there's an error. This makes distribution hard for players not being regular on this forum. (However I want to see if I can fix more bugs, otherwise I don't think releasing this small "patch" will be worth anything... -> that means I won't give it out with "only" that small fix)

Well, I guess that's all I wanted to say for now ^^
But wait, aren't there some other KF-Team members around here who also have the complete KF 2.1 code? Maybe you can hand it over to me, because I don't think you'll be doing much with it... ;D


Current changelog:

* [FIX] all surviving(!) players now get their fair share of the "Wave End Cash Bonus": every player gets the team-score divided by the player count
* [FIX] player-money and team-money can't fall below 0
* [FIX] healing yourself will not heal others standing in front of you
* [FIX] the last entry in the spawn-list with a chance of 1 now can spawn, too (therefore Medikits can now spawn, too)
* [FIX] players always get the starting cash set up by the server when joining the game
* [FIX] spectators can join if there are less spectators than MaxSpectators, even if the playerlimit is already reached
* [CHANGE] removed "ambientglow" from zombies
* [CHANGE] players that don't have a default KF player model selected will be kicked with an error message
* [NEW] healing other players gives 10 $
* [possible FIX] zombies don't stand around after killing a player
* [possible FIX] scoreboard showing duplicate player names
* [possible FIX] stalkers now uncloak on clients when their head is removed (some testing showed that it didn't work)

[zynthetic]

The uc scripts exported from UEd (or ucc export) are the same used when originally imported.
You may be better off subclassing existing classes that use custom content and writing a checkreplacement mutator to replace them ingame. The reason why skins/models look bad and things are missing after recompiling is the same reason why there will never be another large update. Exporting scripts does not export meshes, textures, and sounds (sources which were lost in a hdd failure). So when you recompile it'll probably generate lots of errors about not being able to find content.
Subclass, checkreplacement. If you want to fix bugs, subclass the gametype also.

[AndiNo]

The zombies had no skins because they had none given to them. Their skin was Skin="" or similar. This was fixed however after I exported it with UED. So that problem doesn't occur anymore.
However I get the problem that all fonts in the game or menu are yellow instead of red.

divide said:

sources which were lost in a hdd failure

But the scripts are from the original KF 2.1 version so there can't be any new content that cannot be found, right?

@checkreplacement
You mean that I should try to pack all the fixes into a mutator that people can download? And therefore I should use checkreplacement (I read about it a bit) to replace the normal KFGameType? Is it possible to replace only certain functions? Or do I have to replace the whole KFGameType?

[AndiNo]

Making subclasses of the existing KF ones seems to be a good idea, however I think there will be some problems using them. There are many cases where the game (the KF scripts) checks for the gametype "KFGameType". If I make a subclass KFGameTypePatch for example I don't think it will recognise it as KFGameType. That means many of the original scripts will be broken and I will have to change the original KF scripts anyway.
So for the time being I will stick to changing the KF scripts directly. Without more knowledge of UT coding I think this will be less work than making subclasses and mutators (although I managed to create my own mutator - however I couldn't replace KFGameType wit my own gametype). I will then compile the KFMod.u and release it "when it's done"

[zynthetic]

No one is going to overwrite their KFMod.u and break compatability with release versions.
Checkreplacement only works for mutators. If you're making gameplay fixes subclass the gametype and define a new gametype via int. You'll also save space by not having to rewrite sections of script that are not being changed.

Sources = meshes, textures, sounds. All the content you'll probably notice is getting a lot of IMPORT defines in the begining of a lot of parent classes. Script can be exported verey easily, meshes not so easily.

[AndiNo]

divide said:

No one is going to overwrite their KFMod.u and break compatability with release versions.

Well, I would I presumed that (if the patch is "mature") most people would use it.

define a new gametype via int.

By "int"?
From what I have seen if I make a subclass of the gametype all checks for the KFGameType will break and I will have to change them to my gametype. This would result in another new KFMod.u file. Or I'm getting something wrong^^

PS: I just made a change that healing other players gives the "healer" 10$ per healing. That's something Alex already wanted to implement AFAIK.

[manhunt0r]

andino said:

divide said:

PS: I just made a change that healing other players gives the "healer" 10$ per healing. That's something Alex already wanted to implement AFAIK.

i hope u also made a check for the targeted players hp amount

if(target.health<100)
controller score=controller.score+10;

or something like that ;D

[zynthetic]

Or you could create a new class that ppl would be able to use w/o breaking compatability. It's not necessary at all to overwrite anything unless it's being completely rewritten (like kf1 -> kf2).
Just make a new package and subclass the classes you're modifying. You'll save yourself some headaches and ppl may actually use it. An int isn't crucial, it just tells 2k4 what gametypes/mutators to load in the menus.

[AndiNo]

manhunt0r said:

i hope u also made a check for the targeted players hp amount

To be precise, it's if ( KFHumanPawn(HitActor).Health < KFHumanPawn(HitActor).HealthMax )

@zynthetic
Ok, I tried making a new package. I even made a new mutator and a sublass of KFGameType. But how do I tell UT to use them? Even if I add my package in the KFMod20.ini it'll still use the old KFGameType. And obviously I cannot replace the KFGameType actor with checkReplace and ReplaceWith. I tried that but it wasn't replaced by my own.
But even IF it worked with the mutator, what about bugs NOT happening on the server but on the client? Mutators are only applied on the server AFAIK. So if I changed something on the client I would need to overwrite the old KFMod.u or whatever.

So: Tell me how I make UT use MY subclass of one of KFs from my own package instead of the normal KF one. I currently have no clue.
And btw: I don't know what you were referring to with "int". Do you mean the int-files or integers?

[manhunt0r]

if ( KFHumanPawn(HitActor).Health < KFHumanPawn(HitActor).HealthMax )

i wonder what would actually happen if u were to miss a pawn(cast impossible), are such errors critical?

[AndiNo]

Don't know about this, I have not enough experience with UT coding to state something about its workings. However, the code (partially from me) takes care of those situations:
if(KFHumanPawn(HitActor) !=none)
{
// only give money if the player really heals the other player
if ( KFHumanPawn(HitActor).Health < KFHumanPawn(HitActor).HealthMax ) {
Instigator.PlayerReplicationInfo.Score += 10;
Instigator.PlayerReplicationInfo.NetUpdateTime = Level.TimeSeconds - 1;
}
              KFHumanPawn(HitActor).GiveHealth(Syringe(Weapon).HealBoostAmount, 100);
           }

[zynthetic]

.int file, tells 2k4 what to load in the menu.
Even if you dont have one you should be able to load up a map using the gametype via console.

[AndiNo]

As I said, I still have no idea how to change/substitute the original KF data without changing the original .u files. Mutators only work on servers AFAIK, but I will have to change the client, too. However, until I find a solution I will proceed fixing bugs. Found another one yesterday

From now on I will edit my first post to include the most current changelog and list the bugs I found or things I changed.
If anyone has a bug that I'm currently not aware of and that they think has to be fixed may post it here and I'll try my best to fix it. I'm also currently trying to add the mines (possibly from KF1.0, dunno). Should be fun to place mines all around^^

[shubop]

AndiNo, is your ingame name Gordon_Freeman?

[AndiNo]

No, my ingame name is surprisingly AndiNo. ;D